Re: CVS commit: src/sys/compat/linux

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

"Christos Zoulas" <christos%netbsd.org@localhost> writes:

> Module Name:	src
> Committed By:	christos
> Date:		Sun Aug 20 18:08:57 UTC 2023
>
> Modified Files:
> 	src/sys/compat/linux: files.linux
>
> Log Message:
> add inotify (forgot to commit this)
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.22 -r1.23 src/sys/compat/linux/files.linux
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

The compat_linux kernel module is also required to have inotify.
The following patch fixes my error from 'modload compat_linux'.

# modload compat_linux
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_sys_inotify_add_watch' not found
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_sys_inotify_init1' not found
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_sys_inotify_rm_watch' not found
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_inotify_init' not found
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_sys_inotify_init' not found
[ 14619.3999280] kobj_checksyms, 1013: [compat_linux]: linker error: symbol `linux_inotify_fini' not found
[ 14619.3999280] WARNING: module error: unable to affix module `compat_linux', error 8

Patch:
Index: sys/modules/compat_linux/Makefile
===================================================================
RCS file: /cvsroot/src/sys/modules/compat_linux/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- sys/modules/compat_linux/Makefile	9 Oct 2021 07:01:35 -0000	1.6
+++ sys/modules/compat_linux/Makefile	21 Aug 2023 19:37:08 -0000
@@ -9,7 +9,8 @@
 
 .PATH:	${S}/compat/linux/common
 SRCS=	linux_blkio.c linux_cdrom.c linux_errno.c linux_exec.c
-SRCS+=	linux_fdio.c linux_file.c linux_hdio.c linux_ioctl.c
+SRCS+=	linux_fdio.c linux_file.c linux_hdio.c linux_inotify.c
+SRCS+=	linux_ioctl.c
 SRCS+=	linux_ipc.c linux_misc.c linux_mtio.c linux_sched.c
 SRCS+=	linux_sg.c linux_signal.c linux_signo.c linux_socket.c
 SRCS+=	linux_sysctl.c linux_termios.c linux_time.c linux_mod.c

Thank you.

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3