Re: CVS commit: src/sys/dev/pci

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

Could you tell me how you test this fix for future reference?


Thanks,

On 2023/08/10 17:24, Taylor R Campbell wrote:
> Module Name:	src
> Committed By:	riastradh
> Date:		Thu Aug 10 08:24:45 UTC 2023
>
> Modified Files:
> 	src/sys/dev/pci: if_vmx.c
>
> Log Message:
> vmxnet(4): Fix various MP bugs.
>
> - Defer reset to workqueue.
>    => vmxnet3_stop_locked is forbidden in softint.
>    => XXX Problem: We still take the core lock in softint, and we
>       still take the core lock around vmxnet3_stop_locked.  TBD.
> - Touch if_flags only under IFNET_LOCK.
>    => Cache ifp->if_flags & IFF_PROMISC in vmxnet3_ifflags_cb.
>    => Don't call vmxnet3_set_rxfilter unless up and running; cache
>       this as vmx_mcastactive.  Use ENETRESET in vmxnet3_ifflags_cb
>       instead of calling vmxnet3_set_rxfilter directly.
>       . (The cache is currently serialized by the core lock, but it
>         might reasonably be serialized by an independent lock like in
>         usbnet(9).)
> - Fix vmxnet3_stop_rendezvous so it actually does something.
>    => New vxtxq_stopping, vxrxq_stopping variables synchronize with
>       Rx/Tx interrupt handlers.
> - Sprinkle IFNET_LOCK and core lock assertions.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.11 -r1.12 src/sys/dev/pci/if_vmx.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

--
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Core Product Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>