Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: [mii locking] Re: CVS commit: src/sys



> Since this change if_udav.c doesn't work. Simply plugging a USB-to-ethernet
> device triggers a page fault on mutex_enter in udav_attach.
> 
> Quickly looking at the code:
> 
> 240 	usbnet_lock_core(un);
> 241 	usbnet_busy(un);
> 242
> 243 // 	/* reset the adapter */
> 244 // 	udav_reset(un);
> 245
> 246 	usbnet_attach(un, "udavdet");
> 
> usbnet_lock_core uses un_pri, but un_pri is initialized only in
> usbnet_attach.

can you move the lock_core/busy calls after attach, and see
if that works?

i'm pretty sure that's OK.  this appears to be the only
driver with this bug from my quick scan of them.

thanks!


.mrg.


Home | Main Index | Thread Index | Old Index