[cpufunc] Re: CVS commit: src/sys/arch

[Maxime Villard <max%m00nbsd.net@localhost>]

> Module Name:    src
> Committed By:   ad
> Date:           Tue May 19 21:40:55 UTC 2020
>
> Modified Files:
>         src/sys/arch/amd64/amd64: cpufunc.S
>         src/sys/arch/i386/i386: cpufunc.S i386func.S
>
> Log Message:
> Make cpu_counter(), cpu_counter32() and tsc_get_timecount() into a single
> preemption-safe routine.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.52 -r1.53 src/sys/arch/amd64/amd64/cpufunc.S
> cvs rdiff -u -r1.40 -r1.41 src/sys/arch/i386/i386/cpufunc.S
> cvs rdiff -u -r1.21 -r1.22 src/sys/arch/i386/i386/i386func.S
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Aliasing functions with different prototypes is wrong.

cpu_counter() returns a uint64_t, so it should have KMSAN_INIT_RET(8).
The two other functions you aliased return uint32_t, so they should have
KMSAN_INIT_RET(4). This can't be reconciled because of the alias.

Please revert this change.