Re: CVS commit: src/sys/kern

[Christoph Badura <bad%bsd.de@localhost>]

On Sat, Jan 05, 2019 at 06:03:41PM +0000, Michael van Elst wrote:
> Modified Files:
> 	src/sys/kern: kern_subr.c
> Log Message:
> Restore code to create md0, this fixes booting an INSTALL kernel.

This still does not restore the original functionality that was removed
without explanation or discussion.

If you hadn't reversed the order of

tftproot_dhcpboot()
if (md_is_root) ...
rootspec = bootspec

that would wouldn't have need fixing because tftproot_dhcpboot() sets
md_is_root.

Why was the order reversed anyway?  Can you please explain?

Can you also please respond to the review remarks?

And what about the timing?  Can you please explain what exactly the
idea was to jump in, make these changes, and rush in after you noticed
someone else was working on that code?  That seemed pretty rude to me.
These changes don't look like they were particularly urgent.

I ask you to kindly refrain from making uncoordinated changes to code that
other people are working on.

--chris