Re: CVS commit: src/sys/sys

[Maxime Villard <max%m00nbsd.net@localhost>]

Le 22/08/2018 à 14:14, Robert Elz a écrit :
> Module Name:	src
> Committed By:	kre
> Date:		Wed Aug 22 12:14:29 UTC 2018
>
> Modified Files:
> 	src/sys/sys: asan.h
>
> Log Message:
> Temporarily disable the dummy inline funcs, and replace them with
> __nothing until maxv sorts out the type issues - kern_malloc()
> (for historical reasons) takes an unsigned long parameter, not a
> size_t - on 64 bit arch's this makes no difference (size_t is unsigned
> long) but that's not true on 32 bit archs (or not all of them anyway).
>
> This should unbreak the i386 build (others?) - hopefully without
> damaging anything too badly.    Note the type issues need fixing,
> just making this change permanent is not the solution.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.4 -r1.5 src/sys/sys/asan.h
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Shouldn't we make kern_malloc take a size_t? In the end it calls kmem_alloc
which does take a size_t.

The reason we should not use __nothing is because it leaves unused
variables, and causes warnings.