Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/npf/npfctl



In article <20141226204438.C52549A%cvs.netbsd.org@localhost>,
Mindaugas Rasiukevicius <source-changes-d%NetBSD.org@localhost> wrote:

>+	if (modctl(MODCTL_LOAD, &args) != 0 && errno != EEXIST) {
>+		fprintf(stderr, "WARNING: bpfjit is not loaded; "
>+		    "this may have severe impact on performance.");

This is too much magic I think, and in either case it should be:

	warn("autoloading bpfjit failed; "
	    "performance will severely be degraded");

So that the reason and the program name are printed...

christos



Home | Main Index | Thread Index | Old Index