Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/distrib/utils/embedded



On Sat, 6 Apr 2013, Izumi Tsutsui wrote:

If the problem is overflow of the image, shouldn't the "extra" variable
in each config file be bumped instead of changing a unit?

Sorry for the messy commit. I just changed the -b line the way I did
because I'm not sure where extra comes from and version 1.37 broke every
img that I tried to build.

In such case, asking comitter (or filing PR) would be better.

I did, and heard no objections to my change.

"extra" is defined in config files in src/distrib/utils/embedded/conf
and probably it's required because ffs size calculation in makefs(8)
is not so accurate.
http://nxr.netbsd.org/xref/src/usr.sbin/makefs/ffs.c#590

I'm still not sure that the end-result (even though I didn't know where
EXTRA came from) was wrong.

As I said before, you can change it if you think it's wrong.

--
Hisashi T Fujinaka - htodd%twofifty.com@localhost
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte


Home | Main Index | Thread Index | Old Index