Re: CVS commit: src/sys/dev/wscons

[Michael <macallan1888%gmail.com@localhost>]

Hello,

On Wed, 29 Jun 2011 04:23:00 +0000 (UTC)
christos%astron.com@localhost (Christos Zoulas) wrote:

> In article <20110629030617.0D3DC175D0%cvs.netbsd.org@localhost>,
> Michael Lorenz <source-changes-d%NetBSD.org@localhost> wrote:
> >-=-=-=-=-=-
> >
> >+struct wsdisplayio_edid_info {
> >+    int buffer_size;
> >+    int data_size;
> >+    uint8_t *edid_data;
> >+};
> 
> Shouldn't the sizes be size_t or uintXX_t?
> Signed sizes lead to bugs.

True.

> Shouldn't edit_data be void *?

The EDID block is a byte array and read as such.

have fun
Michael