Re: bouyer-xenamd64 merged

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Fri, Nov 23, 2007 at 09:22:41PM +0900, Masao Uebayashi wrote:
> > IMO, the code needs a lot of cleanup. Personally I don't like the tons of
> >
> > #ifdef XEN
> > ...
> > #else
> > ...
> > #endif
> >
> > blocks. A few of them are ok, but they are too numerous now.
> 
> #ifdef's that switches by models make code hard to understand.  I'd
> want to see #ifdef's by features (#ifdef HAS_FOO and #ifdef IS_BAR)
> even in MD code.  IMHO.

But XEN is a feature :)

-- 
Manuel Bouyer, LIP6, Universite Paris VI.           
Manuel.Bouyer%lip6.fr@localhost
     NetBSD: 26 ans d'experience feront toujours la difference
--