pkgsrc-users: Re: pkg_comp build lang/ocaml makes too small package (2006Q1)

Subject: Re: pkg_comp build lang/ocaml makes too small package (2006Q1)
To: Rhialto <rhialto@falu.nl>
From: Johnny Lam <jlam@pkgsrc.org>
List: pkgsrc-users
Date: 04/04/2006 10:36:07

Rhialto wrote:
> 
> $ make show-var VARNAME=PLIST_SRC
> /vol1/rhialto/cvs/pkgsrc/lang/ocaml/PLIST.stub
> 
> It looks like in this fragment:
> 
> .if (${MACHINE_ARCH} == "i386") || (${MACHINE_ARCH} == "powerpc") || \
>     (${MACHINE_ARCH} == "sparc")
> BUILD_TARGET+=  opt opt.opt
> PLIST_SRC=      ${PKGDIR}/PLIST.opt
> .  if (${OPSYS} != "Darwin") && \
>       !(${OPSYS} == "SunOS" && ${MACHINE_ARCH} == "i386") && \
>       !(${OPSYS} == "NetBSD" && ${MACHINE_ARCH} == "sparc")
> PLIST_SRC+=     ${PKGDIR}/PLIST.prof
> .  endif
> PLIST_SRC+=     ${PKGDIR}/PLIST
> .endif
> 
> the last .endif should be moved up a bit - ${PKGDIR}/PLIST is only added
> if the condition is true.

Your analysis and fix is correct.  I've committed your change to pkgsrc.

	Thanks!

	-- Johnny Lam <jlam@pkgsrc.org>