Re: CVS commit: pkgsrc/databases/gdbm

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Thu, May 02, 2024 at 07:00:41AM +0100, Jonathan Perkin wrote:
> * On 2024-05-02 at 00:30 BST, Aleksey Cheusov wrote:
> 
> > On May 1, 2024 10:37:28 PM UTC, Jonathan Perkin <jperkin%mnx.io@localhost> wrote:
> > 
> > > Again, all of these changes are wrong.  The buildlink3 logic must
> > > match that of the package, including checking PKG_BUILD_OPTIONS.
> > > 
> > > All of these commits are just breaking every package that depends on
> > > them.
> > 
> > Could you explain please what exactly is wrong? I tested my changes on
> > NetBSD and Linux with and without nls option. Everything worked just
> > fine.
> 
> The pkglint warning you should have gotten when running before commit
> explains it quite well:
> 
>   $ cd databases/gdbm
>   $ pkglint -e
>   WARN: buildlink3.mk:13: "../../devel/gettext-lib/buildlink3.mk" is included unconditionally here and conditionally in options.mk:14 (depending on PKG_OPTIONS).
> 
>       When including a dependent file, the conditions in the buildlink3.mk
>       file should be the same as in options.mk or the Makefile.
> 
>       To find out the PKG_OPTIONS of this package at build time, have a
>       look at mk/pkg-build-options.mk.
> 
> Includes in buildlink3.mk MUST match the binary package, otherwise you will
> get all of the errors I linked to in the daily bulk build, for example:
> 
>   https://us-central.manta.mnx.io/pkgsrc/public/reports/upstream-trunk/20240501.2249/py311-flit_core-3.9.0nb1/configure.log
> 
>   ===> Creating toolchain wrappers for py311-flit_core-3.9.0nb1
>   ERROR: gettext-lib>=0.22 is not installed; can't buildlink files.
>   *** Error code 1
> 
> That one is from the python311 breakage, but when the hg export catches up
> there will be many more breakages from all of the other packages you've
> changed.
> 
> There are plenty of examples you can copy from if you search for
> PKG_BUILD_OPTIONS across the tree.
> 
> On a separate note it would be nice to see PRINT_PLIST_AWK being added when
> modifying PLIST files for options.  It's almost guaranteed that on the next
> update to the package these will get lost otherwise.

A reproducer is probably to remove 'nls' from the default (or at least
python311) options, building python311 and then trying to build
py-flit_core.

Then python will _not_ pull in gettext-lib, but py-flit_core will
expect it to be there, because python311/buildlink3.mk still uses it.

It should be made optional in buildlink3.mk using PKG_BUILD_OPTIONS
like Jonathan described.
 Thomas