Re: pkg/58264: Enable FAILOVER_FETCH by default

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

The following reply was made to PR pkg/58264; it has been noted by GNATS.

From: Rob Whitlock <rwhitlock22%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/58264: Enable FAILOVER_FETCH by default
Date: Thu, 16 May 2024 20:58:08 -0400

 > On May 16, 2024, at 8:35 PM, J=C3=B6rg Sonnenberger <joerg%bec.de@localhost> =
 wrote:
 > On Friday, May 17, 2024 1:20:00=3DE2=3D80=3DAFAM GMT+2 =
 rwhitlock22%gmail.com@localhost wrot=3D
 > e:
 >>> How-To-Repeat:
 >> Read pkgsrc/mk/fetch/fetch.mk and discover that FAILOVER_FETCH needs =
 to b=3D
 > e defined for checksums to be checked.
 >=20
 > That's not true. Distfiles are always checked (unless the check is =
 explicit=3D
 > ly
 > disabled) in the "checksum" phase. With FAILOVER_FETCH, the check is
 > earlier and the newly fetched file is thrown away if it doesn't match. =
 So
 > unless a mirror later in the list does have the correct file, it will =
 try o=3D
 > ver
 > and over to fetch the url. Given that we have distfiles that are 100s =
 of MB,
 > that can waste a lot of network IO.
 >=20
 > I'm not saying that the current default is the best, but your =
 description
 > is certainly not right and there is a purpose behind the current =
 setting.
 >=20
 > Joerg
 
 Thanks for the clarification. I didn't think that it would be done in =
 two places.
 
 Having the "checksum" phase do it works for me. Unless someone else has =
 a reason to make FAILOVER_FETCH the default, this PR can be closed.=