pkg/58247: graphics/krita requires libmypaint

[oshima-ya%yagoto-urayama.jp@localhost]

>Number:         58247
>Category:       pkg
>Synopsis:       graphics/krita requires libmypaint
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 11 23:55:00 +0000 2024
>Originator:     Yaushi Oshima
>Release:        pkgsrc-current after 2024-03-14, pkgsrc-2024Q1
>Organization:
>Environment:
NetBSD sudachi 10.0_STABLE NetBSD 10.0_STABLE (GENERIC) #1: Thu Apr 25 18:07:50 JST 2024  oshima@sudachi:/export/netbsd-10/20240425/obj/amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
Building graphics/krita fails after 5.2.

[ 95%] Building CXX object plugins/paintops/mypaint/CMakeFiles/kritamypaintop_static.dir/MyPaintSensorPack.cpp.o
/pkgbuild/graphics/krita/work/krita-5.2.2/plugins/paintops/mypaint/MyPaintSensorPack.cpp:17:10: fatal error: libmypaint/mypaint-brush-settings-gen.h: No such file or directory
   17 | #include <libmypaint/mypaint-brush-settings-gen.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [plugins/paintops/mypaint/CMakeFiles/kritamypaintop_static.dir/build.make:104: plugins/paintops/mypaint/CMakeFiles/kritamypaintop_static.dir/MyPaintSensorPack.cpp.o] Error 1

After Krita 5, it requires libmypaint for mypaint brush.
>How-To-Repeat:
make in pkgsrc/graphics/krita
>Fix:
Add buildlink  for graphics/libmypaint

--- a/graphics/krita/Makefile.orig
+++ b/graphics/krita/Makefile
@@ -58,6 +58,7 @@ 
 .include "../../graphics/lcms2/buildlink3.mk"
 .include "../../graphics/libheif/buildlink3.mk"
 .include "../../graphics/libkdcraw/buildlink3.mk"
+.include "../../graphics/libmypaint/buildlink3.mk"
 .include "../../graphics/libraw/buildlink3.mk"
 .include "../../graphics/libwebp/buildlink3.mk"
 .include "../../graphics/opencolorio/buildlink3.mk"

And add files in PLIST for mypaint brush.

--- graphics/krita/PLIST.orig
+++ graphics/krita/PLIST
@@ -87,6 +87,7 @@ 
 lib/kritaplugins/kritametadataeditor.so
 lib/kritaplugins/kritamodifyselection.so
 lib/kritaplugins/kritamultigridpatterngenerator.so
+lib/kritaplugins/kritamypaintop.so
 lib/kritaplugins/kritanoisefilter.so
 lib/kritaplugins/kritanormalize.so
 lib/kritaplugins/kritaoffsetimage.so
@@ -444,6 +445,7 @@
 share/krita/images/krita-filterop.png
 share/krita/images/krita-grid.png
 share/krita/images/krita-hatching.png
+share/krita/images/krita-mypaint.png
 share/krita/images/krita-paintbrush.png
 share/krita/images/krita-particle.png
 share/krita/images/krita-sketch.png
@@ -475,6 +477,16 @@ share/krita/paintoppresets/Sketch.tag
 share/krita/paintoppresets/Textures.tag
 share/krita/paintoppresets/a)_Eraser_Circle.kpp
 share/krita/paintoppresets/b)_Basic-5_Size_default.kpp
+share/krita/paintoppresets/c)_Pencil_1_Sketch_(mypaint).myb
+share/krita/paintoppresets/c)_Pencil_1_Sketch_(mypaint)_prev.png
+share/krita/paintoppresets/c)_Pencil_2b_(mypaint).myb
+share/krita/paintoppresets/c)_Pencil_2b_(mypaint)_prev.png
+share/krita/paintoppresets/d)_Ink_pen_(mypaint).myb
+share/krita/paintoppresets/d)_Ink_pen_(mypaint)_prev.png
+share/krita/paintoppresets/e)_Marker_Medium_(mypaint).myb
+share/krita/paintoppresets/e)_Marker_Medium_(mypaint)_prev.png
+share/krita/paintoppresets/e)_Marker_Plain_(mypaint).myb
+share/krita/paintoppresets/e)_Marker_Plain_(mypaint)_prev.png
 share/krita/paintoppresets/j)_WaterC_Basic_Lines-Dry.kpp
 share/krita/paintoppresets/j)_WaterC_Basic_Lines-Wet-Pattern.kpp
 share/krita/paintoppresets/j)_WaterC_Basic_Lines-Wet.kpp
@@ -489,6 +501,10 @@
 share/krita/paintoppresets/j)_WaterC_Spread.kpp
 share/krita/paintoppresets/j)_WaterC_Spread_WideArea.kpp
 share/krita/paintoppresets/j)_WaterC_Water-Pattern.kpp
+share/krita/paintoppresets/i)_Wet_Knife_Plus_(mypaint).myb
+share/krita/paintoppresets/i)_Wet_Knife_Plus_(mypaint)_prev.png
+share/krita/paintoppresets/i)_Wet_Paint_Plus_(mypaint).myb
+share/krita/paintoppresets/i)_Wet_Paint_Plus_(mypaint)_prev.png
 share/krita/palettes/animation-color-set.gpl
 share/krita/palettes/concept-cookie.gpl
 share/krita/palettes/default.gpl