pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/58110: New pkgsrc textproc/jnv: an interactive JSON viewer and jq filter editor.
The following reply was made to PR pkg/58110; it has been noted by GNATS.
From: Thomas Klausner <wiz%gatalith.at@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc:
Subject: Re: pkg/58110: New pkgsrc textproc/jnv: an interactive JSON viewer
and jq filter editor.
Date: Thu, 4 Apr 2024 08:31:23 +0200
On Thu, Apr 04, 2024 at 04:40:00AM +0000, nonakap%gmail.com@localhost wrote:
> XMAINTAINER= nonaka%NetBSD.org@localhost
> XHOMEPAGE= https://github.com/ynqa/jnv
> XCOMMENT= an interactive JSON viewer and jq filter editor.
Please run pkglint - it will tell you to simplify this to
"Interactive JSON viewer and jq filter editor"
> X# j9-sys required clang
> XPKGSRC_COMPILER= clang
What happens with gcc?
> Xdo-install:
> X ${INSTALL_PROGRAM} ${WRKSRC}/target/release/jnv \
> X ${DESTDIR}${PREFIX}/bin
Is there some documentation that could be installed? README.md or a
man page?
> sed 's/^X//' >textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_builtin.c << 'END-of-textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_builtin.c'
> X$NetBSD$
> X
> X--- ../vendor/j9-sys-0.1.3/jq/src/builtin.c.orig 2006-07-24 01:21:28.000000000 +0000
> X+++ ../vendor/j9-sys-0.1.3/jq/src/builtin.c 2024-04-04 04:12:43.475984435 +0000
> X@@ -1440,7 +1440,7 @@ static jv f_strptime(jq_state *jq, jv a,
> X }
> X #endif
> X const char *end = strptime(input, fmt, &tm);
> X- if (end == NULL || (*end != '\0' && !isspace(*end))) {
> X+ if (end == NULL || (*end != '\0' && !isspace((unsigned char)*end))) {
> X return ret_error2(a, b, jv_string_fmt("date \"%s\" does not match format \"%s\"", input, fmt));
> X }
> X jv_free(b);
> END-of-textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_builtin.c
> echo x - textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_main.c
> sed 's/^X//' >textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_main.c << 'END-of-textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_main.c'
> X$NetBSD$
> X
> X--- ../vendor/j9-sys-0.1.3/jq/src/main.c.orig 2006-07-24 01:21:28.000000000 +0000
> X+++ ../vendor/j9-sys-0.1.3/jq/src/main.c 2024-04-04 03:57:03.358313910 +0000
> X@@ -126,7 +126,7 @@ static void die() {
> X }
> X
> X static int isoptish(const char* text) {
> X- return text[0] == '-' && (text[1] == '-' || isalpha(text[1]));
> X+ return text[0] == '-' && (text[1] == '-' || isalpha((unsigned char)text[1]));
> X }
> X
> X static int isoption(const char* text, char shortopt, const char* longopt, size_t *short_opts) {
> END-of-textproc/jnv/patches/patch-.._vendor_j9-sys-0.1.3_jq_src_main.c
> exit
Please make sure to send the patches upstream.
Otherwise, looks good, please commit.
Thank you!
Thomas
Home |
Main Index |
Thread Index |
Old Index