pkg/50991: firefox36 errs

[jtowler%soncom.com@localhost]

>Number:         50991
>Category:       pkg
>Synopsis:       firefox36 build fails on i386 NetBSD-7.0
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 22 13:05:00 +0000 2016
>Originator:     John R. Towler
>Release:        NetBSD 7.0  (GENERIC.201509250726Z) i386
>Organization:
	
>Environment:
	
	
System: NetBSD peano.jt.org 7.0 NetBSD 7.0 (GENERIC.201509250726Z) i386
Architecture: i386
Machine: i386
Description:
	there is a type declaration error in firefox36 in xulrunner192 subbuild

How-To-Repeat:

	from bash-4.3# make,

	This is the nohup.out log of the compilation error I thought
	it could be fixed by changing the CXXFLAGS to add -fpermissive
	and this is wrong.  I don't know that much C++, and I don't
	see from the macros in the code how to reach in and fix the
	type mismatch.  I was trying in Dec 2011-Jan 2012 to hand fix
	firefox versions but I did not succeed until pkgsrc solutions
	solved the problem finally.  Sorry about the length of the report.
	
	
nsWildCard.cpp
c++ -o nsWildCard.o -c -I../../dist/system_wrappers -include ../../config/gcc_hid
den.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"NetBSD7\" -DOSARCH=NetBSD -D_IMPL_NS_COM 
-I.. -I. -I. -I../../dist/include -I../../dist/include/nsprpub  -I/usr/local/pkgs
rc/devel/xulrunner192/work/mozilla-1.9.2/dist/include/nspr -I/usr/local/pkgsrc/de
vel/xulrunner192/work/mozilla-1.9.2/dist/include/nss      -I/usr/X11R7/include   
-fPIC -DPIC  -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R
7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/X11R7/include -fno-rtti -
fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-
privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -
O2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/
libdrm -I/usr/X11R7/include/freetype2 -fno-strict-aliasing -Dunix -fshort-wchar -
pthread -pipe  -DNDEBUG -DTRIMMED -O2 -fpermissive  -I/usr/local/include -I/usr/i
nclude -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/free
type2  -I/usr/X11R7/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,
-MD,.deps/nsWildCard.pp nsWildCard.cpp
SpecialSystemDirectory.cpp
c++ -o SpecialSystemDirectory.o -c -I../../dist/system_wrappers -include ../../co
nfig/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"NetBSD7\" -DOSARCH=NetBSD -D_
IMPL_NS_COM -I.. -I. -I. -I../../dist/include -I../../dist/include/nsprpub  -I/us
r/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/dist/include/nspr -I/usr/loc
al/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/dist/include/nss      -I/usr/X11R
7/include   -fPIC -DPIC  -I/usr/local/include -I/usr/include -I/usr/X11R7/include
 -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/X11R7/include
:
 -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -O2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -fno-strict-aliasing -Dunix -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2 -fpermissive  -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/X11R7/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/SpecialSystemDirectory.pp SpecialSystemDirectory.cpp
nsFastLoadFile.cpp
c++ -o nsFastLoadFile.o -c -I../../dist/system_wrappers -include ../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"NetBSD7\" -DOSARCH=NetBSD -D_IMPL_NS_COM -I.. -I. -I. -I../../dist/include -I../../dist/include/nsprpub  -I/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/dist/include/nspr -I/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/dist/include/nss      -I/usr/X11R7/include   -fPIC -DPIC  -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/X11R7/include -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -O2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -fno-strict-aliasing -Dunix -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2 -fpermissive  -I/usr/local/include -I/usr/include -I/usr/X11R7/in
 clude -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/X11R7/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/nsFastLoadFile.pp nsFastLoadFile.cpp
In file included from nsFastLoadFile.cpp:58:0:
nsFastLoadFile.h:298:18: error: conflicting type attributes specified for 'virtual nsresult nsFastLoadFileReader::ReadSegments(nsWriteSegmentFun, void*, PRUint32, PRUint32*)'
    NS_IMETHODIMP ReadSegments(nsWriteSegmentFun aWriter, void* aClosure,
                  ^
In file included from ../../dist/include/nsIBinaryInputStream.h:10:0,
                 from ../../dist/include/nsIObjectInputStream.h:10,
                 from nsBinaryStream.h:44,
                 from nsFastLoadFile.cpp:57:
:nsBinaryStream.h:113:5: error:   overriding 'virtual nsresult nsBinaryInputStream::ReadSegments(nsWriteSegmentFun, void*, PRUint32, PRUint32*)'
     NS_DECL_NSIINPUTSTREAM
     ^
../../config/rules.mk:1408: recipe for target 'nsFastLoadFile.o' failed
gmake[4]: *** [nsFastLoadFile.o] Error 1
gmake[4]: Leaving directory '/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/xpcom/io'
../config/rules.mk:914: recipe for target 'libs' failed
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory '/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2/xpcom'
config/rules.mk:763: recipe for target 'libs_tier_xpcom' failed
gmake[2]: *** [libs_tier_xpcom] Error 2
gmake[2]: Leaving directory '/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2'
config/rules.mk:773: recipe for target 'tier_xpcom' failed
gmake[1]: *** [tier_xpcom] Error 2
gmake[1]: Leaving directory '/usr/local/pkgsrc/devel/xulrunner192/work/mozilla-1.9.2'
config/rules.mk:726: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2

Stop.
make[2]: stopped in /usr/local/pkgsrc/devel/xulrunner192
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/devel/xulrunner192
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/www/firefox36




	

>Fix:

Unknown