pkg/48965: pkgsrc/converters/ack build failure

[sunagawa.keiki%me.com@localhost]

>Number:         48965
>Category:       pkg
>Synopsis:       pkgsrc/converters/ack build failure
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 05 09:00:00 +0000 2014
>Originator:     SUNAGAWA Keiki
>Release:        pkgsrc-2014Q1, pkgsrc-2014Q2
>Organization:
individual home user
>Environment:
Darwin myMac.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3 21:27:35 PDT 
2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64
>Description:
pkgsrc/converters/ack package fails to build on Darwin 13.3.0, OS X 10.9.4.


>How-To-Repeat:
cd pkgsrc/converters/ack; bmake

...

cc -O -DDEFCODE=0 -DDEFJIS=2 -DENVACK=1 -DLANGCHK=1 -DJCONVSW=1  -c fileio.c
fileio.c:88:20: error: array has incomplete element type 'struct timeval'
        struct timeval  tim[2];
                           ^
fileio.c:88:9: note: forward declaration of 'struct timeval'
        struct timeval  tim[2];
               ^
fileio.c:91:2: warning: implicit declaration of function 'utimes' is invalid in 
C99 [-Wimplicit-function-declaration]
        utimes( name, tim );
        ^
1 warning and 1 error generated.
*** Error code 1

Stop.
bmake: stopped in pkgsrc/converters/ack/work/ack139
*** Error code 1

Stop.
bmake: stopped in pkgsrc/converters/ack
*** Error code 1

Stop.
bmake: stopped in pkgsrc/converters/ack

>Fix:
here's the patch.

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/converters/ack/distinfo,v
retrieving revision 1.3
diff -u -u -r1.3 distinfo
--- distinfo    26 Dec 2012 21:21:38 -0000      1.3
+++ distinfo    5 Jul 2014 08:30:19 -0000
@@ -10,7 +10,7 @@
 SHA1 (patch-codetosjis.c) = 1cf4a11d584a1a4412002d112cd743500275bf99
 SHA1 (patch-codetozen.c) = 9612cf1811489bc251140d611000af551f88ee1a
 SHA1 (patch-euctocode.c) = 75486f92a700fa684602d933dcd337f19ab28763
-SHA1 (patch-fileio.c) = 29485831fff5686bb30c9dc62eefed42727999f3
+SHA1 (patch-fileio.c) = 98848506909493bd6d2de472571f46850fc33e0b
 SHA1 (patch-kanjicheck.c) = c37f252c11df5960f9018d21eda9d12bc272c8ef
 SHA1 (patch-kanjicode.h) = f44671c45d2ed7f0a173db84e6c1f10ad1c13f82
 SHA1 (patch-kmain.c) = d0e0d31598febf75c633cf29989279e1aa492de8
Index: patches/patch-fileio.c
===================================================================
RCS file: /cvsroot/pkgsrc/converters/ack/patches/patch-fileio.c,v
retrieving revision 1.1
diff -u -u -r1.1 patch-fileio.c
--- patches/patch-fileio.c      26 Dec 2012 21:21:38 -0000      1.1
+++ patches/patch-fileio.c      5 Jul 2014 08:30:19 -0000
@@ -9,12 +9,13 @@
 - use a bit of const
 - remove wrong usage of utime(3) and use utimes(3)
 
---- fileio.c.orig      1994-06-12 05:31:00.000000000 +0000
-+++ fileio.c
-@@ -5,14 +5,18 @@
+--- fileio.c.orig      1994-06-12 14:31:00.000000000 +0900
++++ fileio.c   2014-07-04 23:38:29.000000000 +0900
+@@ -5,14 +5,19 @@
  /* v1.10  1994 03/19  Ogasawara Hiroyuki              */
  
  #include      <stdio.h>
++#include      <sys/time.h>
 +#include      <utime.h>
 +
 +#include      "kanjicode.h"
@@ -32,7 +33,7 @@
  unsigned char prebuf[PRESIZE],
                *preptr= prebuf;
  
-@@ -36,7 +40,7 @@ unsigned int code;
+@@ -36,7 +41,7 @@
  }
  
  int
@@ -41,7 +42,7 @@
  {
        if( cstackptr > cstack )
                return  *--cstackptr;
-@@ -48,7 +52,7 @@ getcode()
+@@ -48,7 +53,7 @@
  }
  
  void
@@ -50,7 +51,7 @@
  {
        *cstackptr++= code;
  }
-@@ -62,31 +66,33 @@ void       *cp;
+@@ -62,31 +67,33 @@
  }
  
  #if HUMAN