pkg/38806: x11/libgnomekbd doesn't compile in DragonFly BSD

[hasso%estpak.ee@localhost]

>Number:         38806
>Category:       pkg
>Synopsis:       x11/libgnomekbd doesn't compile in DragonFly BSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 31 09:20:01 +0000 2008
>Originator:     Hasso Tepper
>Release:        DragonFly
>Organization:
>Environment:
DragonFly
>Description:
x11/libgnomekbd doesn't compile in DragonFly BSD because NULL = 0 in it. It 
hasn't been a real problem so far, because DragonFly amd64 port isn't yet 
functional and gcc just warns about it in some situations. But x11/libgnomekbd 
mow uses -Werror:

cc1: warnings being treated as errors
gkbd-indicator-config.c: In function 'gkbd_indicator_config_init':
gkbd-indicator-config.c:216: warning: missing sentinel in function call
gkbd-indicator-config.c:223: warning: missing sentinel in function call
gkbd-indicator-config.c:230: warning: missing sentinel in function call
gmake[3]: *** [libgnomekbdui_la-gkbd-indicator-config.lo] Error 1
>How-To-Repeat:
Try to build x11/libgnomekbd in DragonFly BSD.
>Fix:
I prepared the patch to use (void *) casts where needed. Alternatively -Werror 
could be disabled, but I personally wouldn't choose this path - it may mask 
other problems.

The issue with NULL will be fixed in DragonFly, but not backported to the older 
releases, so it has to be worked around in pkgsrc for now.

The patch to fix the problem is available at:
http://leaf.dragonflybsd.org/~hasso/pkgsrc-x11-libgnomekbd.patch