Re: pkg/38036: squid startup rc-file broken in pkgsrc-2007Q4

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

The following reply was made to PR pkg/38036; it has been noted by GNATS.

From: Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: taca%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
pkgsrc-bugs%NetBSD.org@localhost,
        Wolfgang.Stukenbrock%nagler-company.com@localhost
Subject: Re: pkg/38036: squid startup rc-file broken in pkgsrc-2007Q4
Date: Tue, 19 Feb 2008 12:27:13 +0100

 Hi,
 
 the previous variable start_cmd has command_args included!
 If there is a different config file specified than the default, squid 
 may fail to locate the cache-directory.
 Due to the fact that squid seems to ignore other options than "-f" on 
 the command line if "-z" is given, the command_args should be added in 
 the create_dirs function too.
 
 In the part at the end of the file (for non-NetBSD startup), start_cmd 
 is used again. It should be replaced there too.
 
 In general the aproach of current will solve this issue.
 
 Best regards
 
 W. Stukenbrock
 
 Takahiro Kambe wrote:
 
 > The following reply was made to PR pkg/38036; it has been noted by GNATS.
 > 
 > From: Takahiro Kambe <taca%back-street.net@localhost>
 > To: gnats-bugs%NetBSD.org@localhost, 
 > Wolfgang.Stukenbrock%nagler-company.com@localhost
 > Cc: 
 > Subject: Re: pkg/38036: squid startup rc-file broken in pkgsrc-2007Q4
 > Date: Tue, 19 Feb 2008 12:17:11 +0900 (JST)
 > 
 >  In message <20080215134500.ED11B63B293%narn.NetBSD.org@localhost>
 >      on Fri, 15 Feb 2008 13:45:00 +0000 (UTC),
 >      Wolfgang Stukenbrock 
 > <Wolfgang.Stukenbrock%nagler-company.com@localhost> wrote:
 >  > >Fix:
 >  >   Undo the changes in the startup file since pkgsrc-2007Q1.
 >  >   The affected file is /usr/pkgsrc/www/squid/files/squid.sh.
 >  > 
 >  >   The following patch will reinsert the missing definition.
 >  > *** squid.sh.orig       Fri Feb 15 14:29:29 2008
 >  > --- squid.sh    Fri Feb 15 14:31:06 2008
 >  > ***************
 >  > *** 16,21 ****
 >  > --- 16,22 ----
 >  >   required_files="${conf_file} @PKG_SYSCONFDIR@/mime.conf"
 >  >   command_args="-Y -f $conf_file"
 >  >   
 >  > + start_cmd="${command} ${command_args}"
 >  >   stop_cmd="stop_nicely"
 >  >   kill_command="${command} -k shutdown"
 >  >   reload_cmd="${command} -k reconfigure"
 >  On pkgsrc's current, ${start_cmd} was replaces with ${command} in
 >  function squid_createdirs().
 >  
 >  Dose it help you?  Or is there still anything insufficiency ?
 >  
 >  Index: files/squid.sh
 >  ===================================================================
 >  RCS file: /cvsroot/pkgsrc/www/squid/files/squid.sh,v
 >  retrieving revision 1.19
 >  retrieving revision 1.20
 >  diff -u -u -r1.19 -r1.20
 >  --- files/squid.sh  21 Jun 2006 12:10:35 -0000      1.19
 >  +++ files/squid.sh  31 Jan 2008 20:01:13 -0000      1.20
 >  @@ -1,6 +1,6 @@
 >   #!@RCD_SCRIPTS_SHELL@
 >   #
 >  -# $NetBSD: squid.sh,v 1.19 2006/06/21 12:10:35 taca Exp $
 >  +# $NetBSD: squid.sh,v 1.20 2008/01/31 20:01:13 adam Exp $
 >   #
 >   
 >   # PROVIDE: squid
 >  @@ -54,7 +54,7 @@
 >   # create the squid cache directories
 >   squid_createdirs()
 >   {
 >  -   ${start_cmd} -z
 >  +   ${command} -z
 >   }
 >   
 >   if [ -f /etc/rc.subr -a -d /etc/rc.d -a -f /etc/rc.d/DAEMON ]; then
 >  
 >