Re: toolchain/58226: building crunched binaries is not MAKE_JOBS save

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR toolchain/58226; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/58226: building crunched binaries is not MAKE_JOBS save
Date: Wed, 15 May 2024 14:18:44 +0200

 mrg identified the culprit in the crunchgen generated .mk fragment,
 e.g. $OBJ/rescue/rescue.mk:
 
 all: ${PROG}.crunched
 ${PROG}.crunched: ${SUBMAKE_TARGETS} .WAIT ${PROG}.strip
 ${PROG}.strip:
         ${MAKE} -f ${PROG}.mk ${PROG}
         @[ -f ${PROG}.unstripped -a ! ${PROG} -nt ${PROG}.unstripped ] || { \
                 ${_MKSHMSG:Uecho} "  strip and clear PaX flags " ${PROG}; \
                 cp ${PROG} ${PROG}.unstripped && \
                 ${OBJCOPY} -S ${OBJCOPY_REMOVE_FLAGS} ${PROG} && \
                 ${PAXCTL} -0 ${PROG} && \
                 touch ${PROG}.unstripped; \
         }
 
 
 This creates ${PROG}.unstripped and modifies it in-place, racing with other
 make instances getting at this job.
 
 Martin