lib/58254: define_key ncurses compat function is incompatible with ncurses

[nia%pkgsrc.org@localhost]

>Number:         58254
>Category:       lib
>Synopsis:       define_key ncurses compat function is incompatible with ncurses
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 13 09:20:00 +0000 2024
>Originator:     Nia Alarie
>Release:        NetBSD 10.0
>Organization:
The constBSD Foundaiton
>Environment:
>Description:
libcurses defines define_key for compatibility with ncurses:

int
define_key(char *sequence, int key_symbol);

ncurses defines it as follows:

extern NCURSES_EXPORT(int) define_key (const char *, int);

These definitions are incompatible.

define_key is an ncurses extension, meaning ncurses is its specification.
>How-To-Repeat:
compile C++ code that uses define_key and get type conversion errors
>Fix: