NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/58235: compat_netbsd32 broken for SIOCGIFDATA



The following reply was made to PR kern/58235; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/58235: compat_netbsd32 broken for SIOCGIFDATA
Date: Wed, 8 May 2024 15:22:39 -0700 (PDT)

 On Wed, 8 May 2024, Paul Goyette wrote:
 
 >> At first glance it is trivial to add. The ioctl arg includes if_data,
 >> which is *nearly* constant size but has a struct timespec at the end,
 >> so the size of the struct will vary slightly (causing the numeric value
 >> of the ioctl to not match) and the only translation needed is a
 >> netbsd32_to_timespec() for ifi_lastchange.
 >
 > Hmmm, IIRC the struct timespec could cause problems as that was
 > changed in compat_50.  So you might need to add more compat code
 > there, too.
 
 This additionall change should probsbly go into some source file
 like compat32_netif_50.c and be added to the compat_netbsd32_50
 module.  This would give us compat32 support for pre- and post-50
 


Home | Main Index | Thread Index | Old Index