Re: PR/58196 CVS commit: src/distrib/common

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR misc/58196; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Jan-Benedict Glaw <jbglaw%lug-owl.de@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: PR/58196 CVS commit: src/distrib/common
Date: Wed, 8 May 2024 11:19:38 +0200

 Yes, I agree - the typical Makefile fragment has something like:
 
 # prepare mutliuser install environment
 image_md_pre:
         ${RM} -f cdrom/boot
         ${INSTALL} ${COPY} -m 0444 ${DESTDIR}/usr/mdec/boot cdrom/boot
         ${RM} -f bootxx.${MACHINE}
         ${INSTALL} ${COPY} -m 0444 ${DESTDIR}/usr/mdec/xxboot bootxx.${MACHINE}
         ${RM} -f cdrom/etc/gettytab cdrom/etc/ttys cdrom/etc/rc
         ${HOST_LN} -fs /tmp/gettytab cdrom/etc/gettytab
         ${INSTALL} ${COPY} ${.CURDIR}/etc.ttys cdrom/etc/ttys
         ${INSTALL} ${COPY} ${.CURDIR}/etc.rc cdrom/etc/rc
         ${INSTALL} ${COPY} -m 0555 ${.CURDIR}/install.sh cdrom/install.sh
         ${MKDIR} ${MKDIRPERM} cdrom/mnt2 cdrom/targetroot
         ${INSTALL} ${COPY} ${SYSINSTDIR}/sysinstmsgs.?? cdrom/usr/share/sysinst/catalog/
         ${TOOL_GZIP} -d -f cdrom/netbsd.gz
 
 and distrib/common/Makefile.bootcd does the main part of the work, especially
 extracting ${CD_SETS} to the staging directory.
 
 I don't see how the mode/user information from extracting ${CD_SETS} is
 preserved (we could generate a mtree spec from it) and the stuff manually
 copied in image_md_pre is not handled anywhere.
 
 So if I overlooked the first part and we already preserve the owner/time 
 information from the set extraction, we only need to deal with the additional
 files copied in image_md_pre. My suggestion would be to add makefs options
 (or one that gets both pairs) to set default owner/permission for files
 and directories not covered in any mtree input and pass that simmilar
 to ${MAKEFS_TIMESTAMP} to the makefs invocation.
 
 If I did not overlook it and set extraction looses all owner/time data,
 we should create an mtree spec file while extracting the sets, and merge
 that with any other specs passed to makefs.
 
 Martin