Re: bin/54574: usr.bin/make/parse.c $Id: 1.231 drops core on NetBSD-5.2 in realpath(3)

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR toolchain/54574; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/54574: usr.bin/make/parse.c $Id: 1.231 drops core on
 NetBSD-5.2 in realpath(3)
Date: Sat, 28 Sep 2019 16:24:12 +0000

 On Thu, Sep 26, 2019 at 08:00:02PM +0000, Simon J. Gerraty wrote:
  >   {
  >   	static Boolean fatal_warning_error_printed = FALSE;
  >  +	char dirbuf[MAXPATHLEN+1];
 
 nit: please use PATH_MAX (more portable) and it doesn't need +1 as it
 is defined to include space for a null terminator.
 
 (unless realpath is wrong...)
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost