Re: PR/53036 CVS commit: src/sys/dist/pf/net

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/53036; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Alexander Nasonov <alnsn%yandex.ru@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, alnsn%NetBSD.org@localhost
Subject: Re: PR/53036 CVS commit: src/sys/dist/pf/net
Date: Mon, 19 Feb 2018 17:50:22 -0500

 On Feb 19,  9:27pm, alnsn%yandex.ru@localhost (Alexander Nasonov) wrote:
 -- Subject: Re: PR/53036 CVS commit: src/sys/dist/pf/net
 
 | Christos Zoulas wrote:
 | > How about adding this?
 | > 
 | > christos
 | > 
 | > +	so->so_cred = kauth_cred_dup(head->so_cred);
 | 
 | panic: kernel diagnostic assertion "(!cpu_intr_p() && !cpu_softintr_p()) || (pc->pc_pool.pr_ipl != IPL_NONE || cold || panicstr != NULL)" failed: file "/home/alnsn/netbsd-8/src/sys/kern/subr_pool.c", line 2179 pool 'kcredpl' is IPL_NONE, but called from interrupt context
 | 
 | Screenshot of the stack trace is here:
 | https://twitter.com/nasonov/status/965692871549517826
 | 
 
 Ok, how about this then?
 
 christos
 Index: uipc_socket2.c
 ===================================================================
 RCS file: /cvsroot/src/sys/kern/uipc_socket2.c,v
 retrieving revision 1.126
 diff -u -u -r1.126 uipc_socket2.c
 --- uipc_socket2.c	6 Jul 2017 17:42:39 -0000	1.126
 +++ uipc_socket2.c	19 Feb 2018 22:49:37 -0000
 @@ -356,6 +356,9 @@
  	}
  	KASSERT(solocked2(head, so));
  
 +	so->so_cred = head->so_cred;
 +	kauth_cred_hold(so->so_cred);
 +
  	/*
  	 * Insert into the queue.  If ready, update the connection status
  	 * and wake up any waiters, e.g. processes blocking on accept().