lib/38767: make src/lib/csu WARNS=4 pass

[murray%river-styx.org@localhost]

>Number:         38767
>Category:       lib
>Synopsis:       make src/lib/csu WARNS=4 pass
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue May 27 10:10:00 +0000 2008
>Originator:     murray armfield
>Release:        NetBSD-current
>Organization:
N/A
>Environment:
NetBSD zeus.river-styx.org 4.99.63 NetBSD 4.99.63 (ZEUS) #0: Tue May 27 
14:32:01 EST 2008  
admin%zeus.river-styx.org@localhost:/vol01/build/obj/sys/arch/amd64/compile/ZEUS
 amd64
>Description:
The compilation of /src/lib/csu fails with WARNS=4 under amd64 because of one 
line in src/lib/csu/common_elf/common.h which initialises __progname to an 
empty string.

Considering each platform sets this variable at the start of program execution, 
isn't it safe to drop the assignment, and then csu passes WARNS=4 on amd64. 
Haven't checked other ports, don't have other ports available.
>How-To-Repeat:
Add a Makefile.inc in the src/lib/csu directory and set WARNS=4 and build.
>Fix:
Index: common.h
===================================================================
RCS file: /cvsroot/src/lib/csu/common_elf/common.h,v
retrieving revision 1.12
diff -u -u -p -r1.12 common.h
--- common.h    18 May 2006 17:54:19 -0000      1.12
+++ common.h    27 May 2008 09:51:04 -0000
@@ -66,7 +66,7 @@ do {                                          \
 static char    *_strrchr(char *, int);

 char   **environ;
-char   *__progname = "";
+char   *__progname;
 struct ps_strings *__ps_strings = 0;

 extern void    _init(void);